ayatana-commits team mailing list archive

[Lars Uebernickel <lars.uebernickel@xxxxxxxxxxxxx>]

Review: Needs Fixing

I'm only commenting on the messagingmenu parts:

* in update_accounts(): don't add a source for each account. Sources should only be added when new messages are available

* in show_evolution(): there's no need to set source count to 0 (and in fact, that's wrong).  Sources are removed by the messaging menu when the user activates them (same goes for draws-attention)

* in e_plugin_lib_enable: messaging_menu_app_register is called when the plugin is disabled, but the call to _unregister when the plugin is disabled is missing.  This way, evolution will stay in the messaging menu after disabling the plugin
-- 
https://code.launchpad.net/~mathieu-tl/evolution-indicator/apply-patches/+merge/134922
Your team ayatana-commits is subscribed to branch lp:evolution-indicator.