ayatana-commits team mailing list archive
-
ayatana-commits team
-
Mailing list archive
-
Message #04131
Re: [Merge] lp:~larsu/evolution-indicator/messaging-menu-fixes into lp:evolution-indicator
Review: Approve
Seems to me like this would be a perpetuating a regression that we have since evo switched to a source registry: accounts won't be updated when added/removed or changed.
Consider adding the necesary code to watch the source registry signals described at https://developer.gnome.org/libedataserver/stable/ESourceRegistry.html#ESourceRegistry.signals in place of your TODO at line 688.
Otherwise, looks good :) Since the code itself looks fine and we already have the above regression, I'm approving the merge.
--
https://code.launchpad.net/~larsu/evolution-indicator/messaging-menu-fixes/+merge/153957
Your team ayatana-commits is subscribed to branch lp:evolution-indicator.
References