banking-addons-drivers team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/70-communication-communication2-clarify+no_communication2_enlarge into lp:~banking-addons-drivers/banking-addons/70-communication-communication2-clarify.

Commit message:
[RFR] Don't enlarge size of now largely unused communication2 field
[RFR] Removing meaningless comment


Requested reviews:
  Banking Addons Drivers (banking-addons-drivers)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/70-communication-communication2-clarify+no_communication2_enlarge/+merge/212613
-- 
https://code.launchpad.net/~therp-nl/banking-addons/70-communication-communication2-clarify+no_communication2_enlarge/+merge/212613
Your team Banking Addons Drivers is requested to review the proposed merge of lp:~therp-nl/banking-addons/70-communication-communication2-clarify+no_communication2_enlarge into lp:~banking-addons-drivers/banking-addons/70-communication-communication2-clarify.

=== modified file 'account_banking_payment/model/payment_line.py'
--- account_banking_payment/model/payment_line.py	2014-03-22 00:53:03 +0000
+++ account_banking_payment/model/payment_line.py	2014-03-25 13:47:10 +0000
@@ -36,15 +36,9 @@
     '''
     _inherit = 'payment.line'
     _columns = {
-        # New fields
         'msg': fields.char('Message', size=255, required=False, readonly=True),
         'date_done': fields.date(
             'Date Confirmed', select=True, readonly=True),
-        # Communication2: enlarge to 128
-        'communication2': fields.char(
-            'Communication 2', size=128,
-            help='The successor message of Communication.',
-        ),
         'transit_move_line_id': fields.many2one(
             # this line is part of the credit side of move 2a 
             # from the documentation