banking-addons-team team mailing list archive

[James Jesudason <james.jesudason@xxxxxxxxxxxxx>]

On Tuesday, 1 May 2012, Stefan Rijnhart wrote:

> On 30-04-12 21:13, Stefan Rijnhart wrote:
>
>>
>> I cannot find any published evidence that there exists such a thing as an
>> IBAN without an ISO code. The horse's mouth states the contrary (from [1],
>> page 11):
>>
>>
> James,
>
> replying to myself not to hasten you for a reaction but I figured the
> above is probably not what you are trying to say anyway. Although I do not
> encounter many Italian account numbers in real life, I tried with a number
> of Italian IBAN numbers that I found on Google, and the shorter form I
> suggested on the bug tracker does consistently solve the following
> exception upon account number validation:
>
> account_banking/sepa/iban.py", line 131, in __extract__
>    result += value[i+4]
> IndexError: string index out of range
>
>
>
> If this is not the problem you encountered, could you please clarify
> further when you find the time.
>
> Yes the error was something like that. I think you may have misunderstood
my comment on the bug. The way that the parser is treating the Iban is
converting IT0911111111... to something like I/T09111/1111... ie. it is
treating the country code as part of the domestic account number (which is
incorrect).

I am finding that the IBAN parsing is not very good in general - is there a
standard Python library we could use instead? Looking at the comments in
the code, it sounds as though it was written as a temporary solution.

I find the whole bank screen to be poorly designed in openerp. I think it
would be better to have a wizard that generated the bank accounts in a way
that is less prone to error.