banking-addons-team team mailing list archive

["Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>]

Holger Brunn (Therp) has proposed merging lp:~therp-nl/banking-addons/6.1-lp933472-bic-not-required into lp:banking-addons.

Requested reviews:
  Banking Addons Team (banking-addons-team)
Related bugs:
  Bug #933472 in Banking Addons: "[6.1, base_iban] BIC is not legally required anymore, constraint should be dropped"
  https://bugs.launchpad.net/banking-addons/+bug/933472

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/6.1-lp933472-bic-not-required/+merge/109842
-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1-lp933472-bic-not-required/+merge/109842
Your team Banking Addons Team is requested to review the proposed merge of lp:~therp-nl/banking-addons/6.1-lp933472-bic-not-required into lp:banking-addons.

=== modified file 'account_banking/account_banking.py'
--- account_banking/account_banking.py	2012-05-02 15:09:49 +0000
+++ account_banking/account_banking.py	2012-06-12 13:35:34 +0000
@@ -1511,6 +1511,11 @@
                        _("The IBAN number doesn't seem to be correct")
                       )
 
+    def _check_bank(self, cr, uid, ids, context=None):
+        #suppress base_iban's constraint to enforce BICs for IBANs
+        #workaround for lp:933472
+        return True
+
     _constraints = [
         # Cannot have this as a constraint as it is rejecting valid numbers from GB and DE
         # It works much better without this constraint!