banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/6.1-lp1073545-meaningful_dates_in_currency_conversion into lp:banking-addons.

Requested reviews:
  Banking Addons Team (banking-addons-team)
Related bugs:
  Bug #1073545 in Banking Addons: "Matching with different currencies in 6.1 will not full reconcile invoices"
  https://bugs.launchpad.net/banking-addons/+bug/1073545

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/6.1-lp1073545-meaningful_dates_in_currency_conversion/+merge/132351
-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1-lp1073545-meaningful_dates_in_currency_conversion/+merge/132351
Your team Banking Addons Team is requested to review the proposed merge of lp:~therp-nl/banking-addons/6.1-lp1073545-meaningful_dates_in_currency_conversion into lp:banking-addons.

=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py	2012-05-07 11:38:26 +0000
+++ account_banking/banking_import_transaction.py	2012-10-31 15:22:21 +0000
@@ -494,7 +494,7 @@
         if from_curr_id != to_curr_id:
             amount_currency = statement_line_pool._convert_currency(
                 cr, uid, from_curr_id, to_curr_id, move_line_amount,
-                round=True, date=time.strftime('%Y-%m-%d'),
+                round=True, date=transaction.move_line_id.date,
                 context=context)
         else:
             amount_currency = move_line_amount
@@ -1560,7 +1560,7 @@
                 from_curr_id = transaction.move_line_id.currency_id and transaction.move_line_id.currency_id.id or transaction.statement_id.company_id.currency_id.id
                 if from_curr_id != to_curr_id:
                     amount_currency = stline_pool._convert_currency(cr, uid, from_curr_id, to_curr_id, move_line_amount, round=True,
-                                                             date=time.strftime('%Y-%m-%d'), context=context)
+                                                             date=transaction.statement_line_id.date, context=context)
                 else:
                     amount_currency = move_line_amount
                 sign = 1