banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name into lp:banking-addons.

Requested reviews:
  Paulius Sladkevičius (komsas)
  Banking Addons Team (banking-addons-team)
Related bugs:
  Bug #1085113 in Banking Addons: "If exist two partners with same name statement importing fails"
  https://bugs.launchpad.net/banking-addons/+bug/1085113

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name/+merge/137996
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name/+merge/137996
Your team Banking Addons Team is requested to review the proposed merge of lp:~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name into lp:banking-addons.

=== modified file 'account_banking/wizard/banktools.py'
--- account_banking/wizard/banktools.py	2012-06-26 11:17:32 +0000
+++ account_banking/wizard/banktools.py	2012-12-04 21:09:21 +0000
@@ -177,13 +177,12 @@
                 'country_id': country_id,
             })],
         ))
-    elif len(partner_ids) > 1:
-        log.append(
-            _('More then one possible match found for partner with name %(name)s')
-            % {'name': name}
-        )
-        return False
     else:
+        if len(partner_ids) > 1:
+            log.append(
+                _('More then one possible match found for partner with name %(name)s')
+                % {'name': name}
+                )
         partner_id = partner_ids[0]
     return partner_id