← Back to team overview

banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~c2c/banking-addons/6.1-account_easy_reconcile-history into lp:banking-addons/bank-statement-reconcile-61

To: mp+140844@xxxxxxxxxxxxxxxxxx
From: "Alexandre Fayolle @ camptocamp" <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Thu, 20 Dec 2012 09:51:30 -0000
In-reply-to: <20121220091726.3898.98778.launchpad@ackee.canonical.com>
Reply-to: mp+140844@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

l.268	+ move_line_ids.extend : standard idiom nowadays is to use += rather than list.extends. Same thing a few lines later. 

LGTM
-- 
https://code.launchpad.net/~c2c/banking-addons/6.1-account_easy_reconcile-history/+merge/140844
Your team Banking Addons Team is subscribed to branch lp:banking-addons/bank-statement-reconcile-61.

References

[Merge] lp:~c2c/banking-addons/6.1-account_easy_reconcile-history into lp:banking-addons/bank-statement-reconcile-61
From: Guewen Baconnier @ Camptocamp, 2012-12-20