← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~endiansolutions/banking-addons/clieop_filename into lp:banking-addons

 

Review: Needs Fixing

Hi Erwin,

this branch includes your other proposal that adds the account_banking_nl_rabobank module. Can you please rebase your changes on a fresh branch of lp:banking-addons/6.1?

Apart from that, it *seems* like you only add the necessary field and form changes but I don't see where it is filled with the ClieOp keyword. Am I missing something?

l.33: suspicious indent but it's not your fault. I see this file already has tabs, not spaces. I will reformat it at the eventual merge.

-- 
https://code.launchpad.net/~endiansolutions/banking-addons/clieop_filename/+merge/141162
Your team Banking Addons Team is subscribed to branch lp:banking-addons.


References