banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True into lp:banking-addons.

Requested reviews:
  Banking Addons Team (banking-addons-team)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True/+merge/141619

This module attempts to unset a flow stop marker in the payment order workflow. However, it did so using the string 'False' which evaluates to True.

-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True/+merge/141619
Your team Banking Addons Team is requested to review the proposed merge of lp:~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True into lp:banking-addons.

=== modified file 'account_direct_debit/workflow/account_payment.xml'
--- account_direct_debit/workflow/account_payment.xml	2011-12-18 22:45:27 +0000
+++ account_direct_debit/workflow/account_payment.xml	2013-01-02 14:49:27 +0000
@@ -12,7 +12,7 @@
             another state, 'sent_wait' between sent and done.
         -->
         <record id="account_payment.act_done" model="workflow.activity">
-            <field name="flow_stop">False</field>
+            <field name="flow_stop" eval="False"/>
         </record>
 
         <record id="trans_done_sent" model="workflow.transition">