banking-addons-team team mailing list archive

["Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>]

Holger Brunn (Therp) has proposed merging lp:~hbrunn/banking-addons/lp-1106831-handle-P into lp:banking-addons.

Requested reviews:
  Stefan Rijnhart (Therp) (stefan-therp)
Related bugs:
  Bug #1106831 in Banking Addons: "Old Dutch postbank numbers give "invalid literal for int() with base 10" when creating clieop file"
  https://bugs.launchpad.net/banking-addons/+bug/1106831

For more details, see:
https://code.launchpad.net/~hbrunn/banking-addons/lp-1106831-handle-P/+merge/145129

Now replacing Ps by zeroes as proposed
-- 
https://code.launchpad.net/~hbrunn/banking-addons/lp-1106831-handle-P/+merge/145129
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

=== modified file 'account_banking_nl_clieop/wizard/clieop.py'
--- account_banking_nl_clieop/wizard/clieop.py	2013-01-14 15:21:11 +0000
+++ account_banking_nl_clieop/wizard/clieop.py	2013-01-28 09:07:36 +0000
@@ -276,8 +276,8 @@
         self.paymentreference = Optional(PaymentReferenceRecord)
         self.description = Optional(DescriptionRecord, 4)
         self.transaction.transactiontype = type_
-        self.transaction.accountno_beneficiary = accountno_beneficiary
-        self.transaction.accountno_payer = accountno_payer
+        self.transaction.accountno_beneficiary = accountno_beneficiary.replace('P', '0')
+        self.transaction.accountno_payer = accountno_payer.replace('P', '0')
         self.transaction.amount = int(round(amount * 100))
         if reference:
             self.paymentreference.paymentreference = reference