← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-logger into lp:banking-addons/bank-statement-reconcile-70

 

Review: Needs Fixing

Hi Nicolas,


Thanks for the merge and improvements. I would suggest not to delete the rec_log field for now as we may need it for one version more (to let the time to users to migrate their datas).

Could you please set it as deprecated instead of removing it ?

The rest looks good to me.

Thanks,


-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-fix-logger/+merge/145139
Your team Banking Addons Team is subscribed to branch lp:banking-addons/bank-statement-reconcile-70.


References