banking-addons-team team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-on-change-voucher into lp:banking-addons/bank-statement-reconcile-70.

Requested reviews:
  Banking Addons Team (banking-addons-team)

For more details, see:
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-fix-on-change-voucher/+merge/145824

statement ext collide with voucher for some on change. As it almost impossible to have a finance installation without voucher, we may add voucher as a dependence on statement ext in order to fix on change, and silent unwanted voucher behavior.

Nicolas
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-fix-on-change-voucher/+merge/145824
Your team Banking Addons Team is requested to review the proposed merge of lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-on-change-voucher into lp:banking-addons/bank-statement-reconcile-70.

=== modified file 'account_statement_ext/__openerp__.py'
--- account_statement_ext/__openerp__.py	2012-12-20 13:37:01 +0000
+++ account_statement_ext/__openerp__.py	2013-01-31 12:08:29 +0000
@@ -27,7 +27,8 @@
  'complexity': 'normal',
  'depends': [
      'account',
-     'report_webkit'
+     'report_webkit',
+     'account_voucher'
      ],
  'description': """
  Improve the basic bank statement, by adding various new features,

=== modified file 'account_statement_ext/statement.py'
--- account_statement_ext/statement.py	2012-12-20 13:41:45 +0000
+++ account_statement_ext/statement.py	2013-01-31 12:08:29 +0000
@@ -549,7 +549,7 @@
             res['account_id'] = receiv_account
         return res
 
-    def onchange_partner_id(self, cr, uid, ids, partner_id, profile_id, context=None):
+    def onchange_partner_id(self, cr, uid, ids, partner_id, profile_id=None, context=None):
         """
         Override of the basic method as we need to pass the profile_id in the on_change_type
         call.
@@ -569,8 +569,9 @@
                 type = 'customer'
         res_type = self.onchange_type(cr, uid, ids, partner_id, type, profile_id, context=context)  # Chg
         if res_type['value'] and res_type['value'].get('account_id', False):
-            return {'value': {'type': type, 'account_id': res_type['value']['account_id']}}
-        return {'value': {'type': type}}
+            return {'value': {'type': type, 'account_id': res_type['value']['account_id'],
+                              'voucher_id': False}}
+        return {'value': {'type': type}} 
 
     def onchange_type(self, cr, uid, line_id, partner_id, type, profile_id, context=None):
         """