← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-on-change-voucher into lp:banking-addons/bank-statement-reconcile-70

 

Review: Needs Fixing

account_statement_ext/__openerp__.py: you are changing the db model, please increment the version number. 

l. 28: s/It also add/It also adds/

l. 66: are your sure about the copyright years?

l. 107-108: these lines can be removed as you are just passing the context to super().create

l. 145 and following: what are the effects of these changes on an instance with the module installed ?
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-fix-on-change-voucher/+merge/146066
Your team Banking Addons Team is subscribed to branch lp:banking-addons/bank-statement-reconcile-70.


References