banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Ah, but this is not about the whitespace in the fields but too much whitespace in the regular expression. The literal ':61:' matches with the original expression ":(?P<recordid>61):", but not with the current expression with the extra whitespace. Maybe if you show the developer the next few lines from an interactive python session he will understand my question better:

  import re
  print re.match(":(?P<recordid>61):", ':61:')
  <_sre.SRE_Match object at 0x7fb041ab3558>
  print re.match('                    :(?P<recordid>61):', ':61:')
  None

l.387 Please do not drop it, but decide in which cases it is fatal and raise an exception. Or don't you want to guarantee the proper parsing of any of the fields?






-- 
https://code.launchpad.net/~endiansolutions/banking-addons/ab61-nl_rabo/+merge/141149
Your team Banking Addons Team is subscribed to branch lp:banking-addons.