banking-addons-team team mailing list archive

Thread
Date

Re: lp:~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line into lp:banking-addons

To: "Ronald Portier \(Therp\)" <ronald@xxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Wed, 06 Feb 2013 20:03:19 -0000
In-reply-to: <20130206170419.9189.73274.launchpad@ackee.canonical.com>
Reply-to: mp+146903@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Thanks for fixing this!

l.8,28 Maybe combine in a single dictionary of possible keys?
l.62 Looks like the last key/value pair is not stored in sepa_dict. You could copy this line after the end of the 'while' loop.

-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line/+merge/146903
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

References

[Merge] lp:~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line into lp:banking-addons
From: Ronald Portier (Therp), 2013-02-06