banking-addons-team team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Hi,

Thanks for this MP. Just my 2 cents: it would be very much appreciated that you note with a comment where do you remove the voucher generation in the 2 overridden function in line : 241 and 303 and let the commented code. Something like:

# --- Start remove of voucher generation
# commented code
# --- End remove of voucher generation

This way, it'll be easier to port/maintain when hook will be available...

What do you think ?
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-voucher-killer/+merge/148434
Your team Banking Addons Team is requested to review the proposed merge of lp:~camptocamp/banking-addons/bank-statement-reconcile-70-voucher-killer into lp:banking-addons/bank-statement-reconcile-70.