← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~camptocamp/banking-addons/bank-statement-reconcile-70-voucher-killer into lp:banking-addons/bank-statement-reconcile-70

 

Review: Needs Information

That's really a personal taste, but I really dislike the usage of ##### for the reStructuredText title ;-)

typos:
l.195
s/normaly/normally/

l.196
s/draf/draft/


Haven't we a smart way to disable the voucher without overriding all this stuff?
For instance, return early from `account_voucher.create` and `account_voucher_line.create` when a specific key is given in the context? Thus we would just have to add this key from the wizards. Did you tried something in thoses lines?
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-voucher-killer/+merge/148434
Your team Banking Addons Team is subscribed to branch lp:banking-addons/bank-statement-reconcile-70.


References