banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Did not notice the changes until you mailed me about them. Please click 'Resubmit Proposal' in the upper right corner of the page (for larger change sets) or drop a comment on this one next time.

In my previous review I encouraged you to make a change to the framework to percolate messages generated in the parsers but instead you chose to just pass the messages up one level to have them logged to the server log. These messages seem to me to be of particular interest to the user so any reason why you chose this path instead, pratically hiding the messages from the user?

The actual parser definition looks good to me now!



-- 
https://code.launchpad.net/~endiansolutions/banking-addons/ab61-nl_rabo/+merge/141149
Your team Banking Addons Team is subscribed to branch lp:banking-addons.