banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban into lp:banking-addons.

Requested reviews:
  Banking Addons Team (banking-addons-team)
Related bugs:
  Bug #1131200 in Banking Addons: "Bug in Iban account_iban_preserve_domestic"
  https://bugs.launchpad.net/banking-addons/+bug/1131200

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban/+merge/154489
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban/+merge/154489
Your team Banking Addons Team is requested to review the proposed merge of lp:~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban into lp:banking-addons.

=== modified file 'account_banking/account_banking.py'
--- account_banking/account_banking.py	2013-01-30 11:34:58 +0000
+++ account_banking/account_banking.py	2013-03-20 19:33:23 +0000
@@ -1520,16 +1520,13 @@
                 if country.code in sepa.IBAN.countries:
                     acc_number_fmt = sepa.BBAN(acc_number, country.code)
                     if acc_number_fmt.valid:
-                        values['acc_number'] = str(acc_number_fmt)
+                        values['acc_number_domestic'] = str(acc_number_fmt)
                     else:
-                        values['acc_number'] = acc_number
                         result.update(warning(
                             _('Invalid format'),
                             _('The account number has the wrong format for %(country)s')
                             % {'country': country.name}
                         ))
-                else:
-                    values['acc_number'] = acc_number
         return result
 
     def onchange_iban(