banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/banking-addons/improve_lookup into lp:banking-addons/bank-statement-reconcile-70

To: mp+154730@xxxxxxxxxxxxxxxxxx
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Fri, 22 Mar 2013 08:22:23 -0000
In-reply-to: <20130321152823.16033.85691.launchpad@ackee.canonical.com>
Reply-to: mp+154730@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM 

On a totally minor side, I'd prefer "import re" and using "re.escape" the code; The reason being that there are several "escape" functions in the stdlib (for xml, cgi, shell command lines, re...) and it is easier for the reader when coming on the code to understand the context with a namespaced call. 
-- 
https://code.launchpad.net/~camptocamp/banking-addons/improve_lookup/+merge/154730
Your team Banking Addons Team is subscribed to branch lp:banking-addons/bank-statement-reconcile-70.

References

[Merge] lp:~camptocamp/banking-addons/improve_lookup into lp:banking-addons/bank-statement-reconcile-70
From: Nicolas Bessi - Camptocamp, 2013-03-21