banking-addons-team team mailing list archive

Thread
Date

Re: lp:~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line into lp:banking-addons

To: "Ronald Portier \(Therp\)" <ronald@xxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Fri, 05 Apr 2013 18:12:19 -0000
In-reply-to: <20130208093822.10737.53513.launchpad@ackee.canonical.com>
Reply-to: mp+147328@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Ronald,

thank you for the refactoring. I am very happy with the current algoritm. Sorry to bother you one more time, but I just have a hard time figuring out what 've' stands for. Using descriptive variables is almost always a good idea. Can you replace this variable name with something that is immediately clear? Please relace 'si' and 'ei' too, even though I managed to figure those out.


-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line/+merge/147328
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

References

[Merge] lp:~therp-nl/banking-addons/6.1_lp1117319_abnamro_sepa_line into lp:banking-addons
From: Ronald Portier (Therp), 2013-02-08