← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~therp-nl/banking-addons/ba7.0-MIG-import into lp:banking-addons/banking-addons-70

 

Review: Needs Fixing code review, no test

I'm really not fond of "import *" in production code, especially if, as in here, there several such imports in the same module. 
I suggest:

* either importing explicitely the symbols you are using
* of importing just the module (maybe with the "as" keyword to perform an on the fly aliasing) and using a qualified access

Question: what do the "AB" comments stand for?
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba7.0-MIG-import/+merge/158654
Your team Banking Addons Team is subscribed to branch lp:banking-addons/banking-addons-70.


References