banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures into lp:banking-addons.

Requested reviews:
  Banking Addons Team (banking-addons-team)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures/+merge/161095
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures/+merge/161095
Your team Banking Addons Team is requested to review the proposed merge of lp:~therp-nl/banking-addons/ba6.1-do_not_match_on_very_short_signatures into lp:banking-addons.

=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py	2013-03-21 13:27:19 +0000
+++ account_banking/banking_import_transaction.py	2013-04-26 11:28:32 +0000
@@ -222,7 +222,7 @@
             Match on ID of invoice (reference, name or number, whatever
             available and sensible)
             '''
-            if invoice.reference:
+            if invoice.reference and len(invoice.reference) > 2:
                 # Reference always comes first, as it is manually set for a
                 # reason.
                 iref = invoice.reference.upper()
@@ -230,7 +230,7 @@
                     return True
             if invoice.type.startswith('in_'):
                 # Internal numbering, no likely match on number
-                if invoice.name:
+                if invoice.name and len(invoice.name) > 2:
                     iname = invoice.name.upper()
                     if iname in ref or iname in msg:
                         return True