banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/banking-addons/6.1-link_partner_wizard into lp:banking-addons

To: mp+160889@xxxxxxxxxxxxxxxxxx
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Mon, 29 Apr 2013 07:35:30 -0000
In-reply-to: <20130425131031.19766.80705.launchpad@ackee.canonical.com>
Reply-to: mp+160889@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

l.183 I think the intended tuple of types was (int, long) instead of (int, float).

l.182 an indentation level could be avoided by returning early in the method (maybe a matter of taste though)

Besides that, LGTM
-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1-link_partner_wizard/+merge/160889
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

References

[Merge] lp:~therp-nl/banking-addons/6.1-link_partner_wizard into lp:banking-addons
From: Stefan Rijnhart (Therp), 2013-04-25