banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/banking-addons/6.1_lp1176783 into lp:banking-addons

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
Date: Mon, 06 May 2013 10:24:26 -0000
In-reply-to: <20130506074429.7190.59946.launchpad@ackee.canonical.com>
Reply-to: mp+162566@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

This would indeed fix the problem at hand.

But if match_type's semantics is 'I have exclusively matches of type $match_type', then all the code in this function is broken. Adhering to the maxim of only fixing the bug in bug fixes, I pushed the necessary fix to lp:~therp-nl/banking-addons/6.1_fix__get_move_info_semantics - this will fix my problem en passant.

So if you confirm that's the right semantics, we can ditch this MP and I'll propose the branch mentioned above.
-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1_lp1176783/+merge/162566
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

References

[Merge] lp:~therp-nl/banking-addons/6.1_lp1176783 into lp:banking-addons
From: Holger Brunn (Therp), 2013-05-06