← Back to team overview

banking-addons-team team mailing list archive

Thread
Date

Re: lp:~therp-nl/banking-addons/6.1_fix__get_move_info_semantics into lp:banking-addons

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Mon, 06 May 2013 11:50:32 -0000
In-reply-to: <20130506111126.31559.23582.launchpad@ackee.canonical.com>
Reply-to: mp+162583@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Yes, I'd call that truely robust. It would be bad if it would only work with a specific implementation of record caching, but the code you referred to does check the record id.

-- 
https://code.launchpad.net/~therp-nl/banking-addons/6.1_fix__get_move_info_semantics/+merge/162583
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

References

[Merge] lp:~therp-nl/banking-addons/6.1_fix__get_move_info_semantics into lp:banking-addons
From: Holger Brunn (Therp), 2013-05-06