← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~akretion-team/banking-addons/bank-statement-reconcile-61-ref-base-completion into lp:banking-addons/bank-statement-reconcile-61

 

Review: Needs Fixing

> I would expect .value to work in 283, but not in 286. But wouldn't you be
> better off to use the string representation for both? Then you don't need to
> know anything about the exception's internals and that's just the idea for the
> rule that exceptions should have a meaningful string representation.
> (ErrorTooManyPartner does that)

Holger is right, as of python 2.6, BaseException.message has been deprecated and should be replaced by the string representation of the exception instead.
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-61-ref-base-completion/+merge/159105
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-61.


References