← Back to team overview

banking-addons-team team mailing list archive

[Merge] lp:~therp-nl/banking-addons/ba70-abnamro_payment_recognition into lp:banking-addons/banking-addons-70

 

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/ba70-abnamro_payment_recognition into lp:banking-addons/banking-addons-70.

Commit message:
[FIX] abnamro payment order recognition

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/ba70-abnamro_payment_recognition/+merge/167303

Same as https://code.launchpad.net/~therp-nl/banking-addons/6.1-abnamro_payment_recognition/+merge/167299
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba70-abnamro_payment_recognition/+merge/167303
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~therp-nl/banking-addons/ba70-abnamro_payment_recognition into lp:banking-addons/banking-addons-70.
=== modified file 'account_banking_nl_abnamro/abnamro.py'
--- account_banking_nl_abnamro/abnamro.py	2013-05-01 14:42:23 +0000
+++ account_banking_nl_abnamro/abnamro.py	2013-06-04 15:01:01 +0000
@@ -90,6 +90,7 @@
         'INTL': bt.ORDER, # international order
         'UNKN': bt.ORDER, # everything else
         'SEPA': bt.ORDER,
+        'PAYB': bt.PAYMENT_BATCH,
     }
 
     def __init__(self, line, *args, **kwargs):
@@ -116,7 +117,7 @@
             elif not self.execution_date:
                 self.error_message = "No execution date"
             elif not self.remote_account and self.transfer_type not in [
-                'BEA', 'GEA', 'COSTS', 'UNKN',
+                'BEA', 'GEA', 'COSTS', 'UNKN', 'PAYB',
                 ]:
                 self.error_message = _('No remote account for transaction type '
                                        '%s') % self.transfer_type
@@ -246,6 +247,8 @@
                 remote_owner = field[14:32].strip()
             elif re.match("^EL[0-9]{13}I", field):
                 transfer_type = 'INTL'
+            elif field.startswith("TOTAAL BETALINGEN"):
+                transfer_type = 'PAYB'
             return (transfer_type, remote_account, remote_owner)
         
         fields = split_blob(self.blob)


Follow ups