banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/ba70-payment_move_line into lp:banking-addons/banking-addons-70.

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/ba70-payment_move_line/+merge/167411

Same as https://code.launchpad.net/~therp-nl/banking-addons/ba61-payment_move_line/+merge/167409
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba70-payment_move_line/+merge/167411
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~therp-nl/banking-addons/ba70-payment_move_line into lp:banking-addons/banking-addons-70.

=== modified file 'account_banking_payment/model/payment_order_create.py'
--- account_banking_payment/model/payment_order_create.py	2013-05-24 09:00:42 +0000
+++ account_banking_payment/model/payment_order_create.py	2013-06-04 21:23:26 +0000
@@ -98,8 +98,12 @@
                     # customer invoice number (in the case of debit order)
                     communication = line.invoice.number.replace('/', '')
                     state = 'structured'
-                    if communication != line.ref:
+                    if line.invoice.number != line.ref:
                         communication2 = line.ref
+            else:
+                state = 'normal'
+                communication2 = line.ref
+
             # support debit orders when enabled
             if (payment.payment_order_type == 'debit' and
                 'amount_to_receive' in line):