banking-addons-team team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Disapprove c

Hi Benoit !


First, thank you very much for this MP and contribution. Your code seems ok for me. It's a very useful one. But I have a problem with the dependencies here.

Firstly, I don't want to merge a module in community addons if it depends on module that are not in the communtiy addons. Here, your rely on module in a branch called http://bazaar.launchpad.net/~akretion-team/file-exchange taht belong to Akretion team... Moreover: file_repository depends on 'file_autotask_rel' that depends on file_document and abstract_automatic_task and file_document that depends also on abstract_automatic_task. 

Here I don't even find the abstract_automatic_task module in that branch.

So if I'm in favor of including this module in that project, I cannot accept that much dependencies on it that are not part of the communtiy addons. Community addons must rely only on other community one to ensure a proper quality.

For those reasons, I must refuse your proposal unless you remove the dependencies or include all of them in community addons.

I hope you understand our point of view here. 

Regards,

Joël


-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-61-repository/+merge/172366
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-61.