banking-addons-team team mailing list archive

Thread
Date

Re: lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70 into lp:banking-addons/bank-statement-reconcile-7.0

To: "Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Thu, 12 Sep 2013 09:29:07 -0000
In-reply-to: <20130911134225.31515.95066.launchpad@ackee.canonical.com>
Reply-to: mp+185047@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

Thanks for the changes!

That's a common issue with tests, when a module adds a NOT NULL constraint on a column, other modules tests do not fill this required field and fails. But I don't think that's something we can avoid.
I think that the most important is to have success results when the module is installed alone.

Looks good to me
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70/+merge/185047
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70 into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2013-09-11