banking-addons-team team mailing list archive

[Serpent Consulting Services <serpentcs.lp@xxxxxxxxx>]

Just looked more in details and found:

1. 'partner_id': fields.related('bank_account_id', 'partner_id'),  Should better have 'relation','string','type' attributes.
2. 'batch_ref': fields.char(size=64) should have a string.
3. 'state' too missed string.
4. customer.payment.request model should have atleast one mandatory field.
5. Majority of your functions do not have a return statement. Should have return True atleast.

Thanks.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/banking-addons/loose-coupling/+merge/185033
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/banking-addons/loose-coupling into lp:banking-addons/bank-statement-reconcile-7.0.