banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Hi Ruchir,

thank you for working on this. I looked at the results, and there are some good things and then some things that I am not sure about.

Let's start at the top of the wizard form view:
The lines under 'Transaction data' have more space between them vertically. I prefer the old spacing.
The exact function of 'Match Again' button is not very clear until you accidentally discover the mouse-over.
The 'Remove duplicate' flag is visible for non-duplicates

The lines under 'Current match' are fine.

Matching invoices or entries manually: the many2many widgets are very big. Can you condense this part of the view?

On matched entries the notebook widget is still visible with pages on write-off and disabling reconciliation, only very obscurely pushed against the bottom. Didn't you plan on eliminating the notebook entirely?

BTW I think the notebook was not very nice but it did lay out all the different options in a structural manner. I miss that structure in the new setup. I think this is very important to improve on.

When I install account_banking_payment, the options to match a payment order or payment line are still in old style, which seems inconsistent.

Menu structure: it would be nice to eliminate 'menu_finance_banking_actions' entirely and place the items from the various payment modules under 'account_payment.menu_main_payment' instead. It is imminent with the uncoupling of the payment export functionality from account_banking anyway.

The methods to generate filenames: would it be an option to you to preserve the original filenames of the uploaded files instead?

Some nits about the code: the translations you add to account_banking/i18n/nl.po belong to account_banking_payment/i18n/nl.po. I prefer "Match deze betalingsregel" over "Match deze betaling lijn".

The spacing of the xml looks dubious in some spaces. Please keep to the standard spacing of 4 and proper indentation.

-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-ui-improvement/+merge/181949
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.