banking-addons-team team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Information code review, no test

Another thing: if date is False, has any meaning to call "self.pool.get('account.period').find(cr, uid, dt=date, context=local_ctx)[0]"?

If not, I would refactor this to:

if not date:
    return False
else:
    self.pool.get('account.period').find...

And I suppose that the try is not neccessary in this case...
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba70-lp1231174-default_method_should_not_raise_at_module_installation_time/+merge/187677
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.