banking-addons-team team mailing list archive

Thread
Date

Re: lp:~therp-nl/banking-addons/ba70-lp1231174-default_method_should_not_raise_at_module_installation_time into lp:banking-addons

To: mp+187677@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Thu, 26 Sep 2013 07:50:16 -0000
In-reply-to: <20130926070534.21729.34315.launchpad@ackee.canonical.com>
Reply-to: mp+187677@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

Hi, Stefan, thank you very much for your comments that teach me another thing. You are right about the recreation on the dictionary, but I'm not sure if the computation price is much higher than the test for None value, does it worth?

Regards.
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba70-lp1231174-default_method_should_not_raise_at_module_installation_time/+merge/187677
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.

References

lp:~therp-nl/banking-addons/ba70-lp1231174-default_method_should_not_raise_at_module_installation_time into lp:banking-addons
From: Stefan Rijnhart (Therp), 2013-09-26