banking-addons-team team mailing list archive

[Raphaël Valyi - http://www.akretion.com <rvalyi@xxxxxxxxx>]

Review: Approve

LGTM, no test

Eventually in account_bank_statement_tax/model/account_bank_statement.py from lines 118 to 127, fiscal position and mapping could be extracted in a sub-function that one could override. But I'm not sure yet if that would really fit for us, so we could always do that later.

That would also be interesting to see how this development relates (or not) with the "tax_on_payment" Anybox module here https://bitbucket.org/anybox/tax_on_payment/src/f34820153981fb7ac96bb2688483d2573db0756d/account.py?at=default
Basically they put a tax on the move at the reconciliation time while you put it when the bank statement is encoded. Not sure if the two things overlap or not.
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba70-bank_statement_tax/+merge/177376
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.