banking-addons-team team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing no test, code review

Hello, 

Thanks for the patch.

Fixed some PEP8 and add some comments

Have you tried to propose a patch to add a hook to prepare the statement on official branch. Generally Olivier is quite open to this kind of small enhancement.

Also I will add a explicit message error if no profile found that tells user there is no profile for current journal.

Regards

Nicolas


-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-pos_compat-afe/+merge/193807
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.