banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing test

Well, I raised some questions earlier on in this thread but maybe I was not clear enough about them. For one thing, it seems that you do attempt to recover the remote account as per l.223, but I was misguided by the comment in l.260 (never mind the commit msg for revision 178 which is slightly off as the commit concerns remote owner, not remote account).

I resorted to some testing in order to make my questions a little more concrete. I have access to MT940 files from Triodos NL. A 'real' statement with 311 transactions did not result in any new bank statement in the system, nor in an error or logged warning so I shrunk it to a statement with a single transaction. It gave me the following error:

account_banking/sepa/iban.py(275)__new__()
-> raise ValueError, 'Invalid chars found in IBAN number'

Now, tag 25, which contains the local account number, has the following layout in my statement file:

    'TRIODOSBANK/0198409192'

It seems this bank's MT940 format is therefore not compatible with this parser as it does not attempt to strip off the bank name here (which supports my earlier argument that a generic parser for MT940 may not be realistic).

For the sake of further testing, I removed the unanticipated bank name from tag 25. The full statement, containing a single transaction, then looked like this:

:20:1384350886127/1
:25:0198409192
:28:1
:60F:C130715EUR9,99
:61:130722D9,00NET NONREF
:86:000>100000000000
>20INGBNL2A
>21NL86INGB0002445588
>22BELASTINGDIENST APELDOORN 8>23850 0371 4630 1060 LOONBELA
>24STING JUNI>310198409192
:62F:C131113EUR0,99
-

I got the following result: no remote owner, no remote account and reference, as well as notes was only "000>100000000000>20INGBNL2A"

I'm sorry if my bank is an anomaly but I think at least you should add to the module description that the Triodos format is known not to work with this module. Setting to 'Needs fixing' for that reason. Meanwhile, my colleague has been planning to test this proposal for Rabobank statements (for which it is designed, I believe) so if you could hold on until then that would be cool.

-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/account_banking_nl_mt940structured/+merge/172233
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/6.1.