banking-addons-team team mailing list archive

[Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>]

Review: Approve code review, no test

I approve this merge.
Note the key "extra_fields" have been introduced here : http://bazaar.launchpad.net/~banking-addons-team/banking-addons/bank-statement-reconcile-70/revision/94#account_statement_base_import/parser/file_parser.py
I thinks it's better to come back with the convertion_dict because the FileParser is an abstract Parser for file, and can be reuse in many case (Paypal, Atos, Paybox...). So the convert dict depend of the implementation of the Parser and can not be generic

-- 
https://code.launchpad.net/~akretion-team/banking-addons/account_statement_base_import_conversion_dict/+merge/198235
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.