banking-addons-team team mailing list archive

Thread
Date

Re: lp:~akretion-team/banking-addons/bank-statement-reconcile-70-account-easy-reconcile-add-commit into lp:banking-addons/bank-statement-reconcile-7.0

To: Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Wed, 11 Dec 2013 14:57:23 -0000
In-reply-to: <20131204171626.32518.52460.launchpad@ackee.canonical.com>
Reply-to: mp+197756@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove code review, no tests

Hi,

Thanks for the contribs.

I'm not convinced by this approach as you may commit some unwanted stuff which is probably worst than having errors and loosing everything. For that reason, I set this MP to disaprove.

Can't you import a part of the writing before launching the reconciliation ? In a "normal" context, the cron will never parse at once that much record right ?

May be I'm missing something here. A second opinion would be welcome and I may change my review then.

Regards,

Joël

-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-account-easy-reconcile-add-commit/+merge/197756
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.