← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-yaml-related-lep into lp:banking-addons/bank-statement-reconcile-7.0

 

Hi Nicolas,

thanks a lot for your review. You're right, I didn't mention that I am developing the tests here:
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-add-tests-lep

I changed the MP description to reflect that.

I made this MP because I need it for my tests to work, before we manage to fix this specific behaviour in openobject. This is a "not too ugly" workaround that "unwinds" a related field and just that.

That said, I definitely agree with you that this needs a bug report. I haven't done it yet because I managed to get a specific workaround (this MP) but I haven't managed to reproduce this in a general case yet (and so, to produce a good quality bug report).

To do that, I think I am going to produce a specific test with the standard account module that fails and explain the situation properly in a bug report (that is, produce a YAML test that uses an object that has a Python constraint on a related store=True field).

I wrote too much, on the PEP8 issues I only say "OK!" :)
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-yaml-related-lep/+merge/199124
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.


References