banking-addons-team team mailing list archive

Thread
Date

Re: lp:~florian-dacosta/banking-addons/bank-statement-reconcile-70-possibility-to-add-transfer-lines into lp:banking-addons/bank-statement-reconcile-7.0

To: mp+198837@xxxxxxxxxxxxxxxxxx
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Thu, 19 Dec 2013 09:56:10 -0000
In-reply-to: <20131212220532.25038.76937.launchpad@ackee.canonical.com>
Reply-to: mp+198837@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Hi,

I don't understand what is the functional purpose of that.
If I understand correctly, you can have 1 refund transfer line and 1 payment transfer line. But what are theses lines concretely? Do you have an example?

I know files where we may have several refunds (N payments, N refunds), is it the same thing?

On a technical viewpoint, why did you add methods get_refund_transfer() and get_payment_transfer()? Couldn't we use the attributes directly?

Thanks!
-- 
https://code.launchpad.net/~florian-dacosta/banking-addons/bank-statement-reconcile-70-possibility-to-add-transfer-lines/+merge/198837
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.