banking-addons-team team mailing list archive

[Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>]

Review: Needs Fixing sct test

Thanks Alexis and Luc for this great effort.

I made a quick test of account_banking_sepa_credit_transfer and it looks good.

In combination with base_iban_bic_not_required however, it complains with Cannot compute 'Debtor BIC' or 'Creditor BIC'. the PAIN xsd have the BIC elements optional. Can you fix that one?

On the nitpicking side, I noticed a few "return True" and the end of generate_*_block methods which are unncessary.


-- 
https://code.launchpad.net/~akretion-team/banking-addons/70-sepa-trf-dd-updates/+merge/200019
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.