banking-addons-team team mailing list archive

[Graeme Gellatly <gdgellatly@xxxxxxxxx>]

Graeme Gellatly has proposed merging lp:~gdgellatly/banking-addons/banking-addons-reconcile-minor-import-fixes into lp:banking-addons/bank-statement-reconcile-7.0.

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~gdgellatly/banking-addons/banking-addons-reconcile-minor-import-fixes/+merge/200475

Minor import fixes plus a couple of other small changes to allow trunk install.
-- 
https://code.launchpad.net/~gdgellatly/banking-addons/banking-addons-reconcile-minor-import-fixes/+merge/200475
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~gdgellatly/banking-addons/banking-addons-reconcile-minor-import-fixes into lp:banking-addons/bank-statement-reconcile-7.0.

=== modified file 'account_statement_base_completion/__init__.py'
--- account_statement_base_completion/__init__.py	2012-12-20 13:37:01 +0000
+++ account_statement_base_completion/__init__.py	2014-01-05 05:46:45 +0000
@@ -19,5 +19,6 @@
 #
 ##############################################################################
 
-import statement
-import partner
+from . import partner
+from . import statement
+

=== modified file 'account_statement_base_completion/partner.py'
--- account_statement_base_completion/partner.py	2012-12-20 13:37:01 +0000
+++ account_statement_base_completion/partner.py	2014-01-05 05:46:45 +0000
@@ -20,7 +20,7 @@
 #################################################################################
 
 from openerp.osv.orm import Model
-from openerp.osv import fields, osv
+from openerp.osv import fields
 
 
 class res_partner(Model):
@@ -32,7 +32,7 @@
 
     _columns = {
         'bank_statement_label': fields.char('Bank Statement Label', size=100,
-                help="Enter the various label found on your bank statement separated by a ; If \
-                 one of this label is include in the bank statement line, the partner will be automatically \
-                 filled (as long as you use this method/rules in your statement profile)."),
+                help="Enter the various label found on your bank statement separated by a ; If "
+                 "one of this label is include in the bank statement line, the partner will be automatically "
+                 "filled (as long as you use this method/rules in your statement profile)."),
             }

=== modified file 'account_statement_base_completion/statement.py'
--- account_statement_base_completion/statement.py	2013-10-16 08:58:12 +0000
+++ account_statement_base_completion/statement.py	2014-01-05 05:46:45 +0000
@@ -23,16 +23,15 @@
 import sys
 import logging
 import simplejson
-
+import datetime
 import psycopg2
 
 from collections import defaultdict
 import re
-from tools.translate import _
+from openerp.tools.translate import _
 from openerp.osv import osv, orm, fields
 from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT
 from operator import attrgetter
-import datetime
 
 _logger = logging.getLogger(__name__)
 

=== modified file 'account_statement_ext/report/bank_statement_report.py'
--- account_statement_ext/report/bank_statement_report.py	2012-12-20 13:40:22 +0000
+++ account_statement_ext/report/bank_statement_report.py	2014-01-05 05:46:45 +0000
@@ -22,7 +22,7 @@
 from openerp.tools.translate import _
 from openerp import pooler
 from datetime import datetime
-from report_webkit import webkit_report
+from openerp.addons.report_webkit import webkit_report
 
 
 class BankStatementWebkit(report_sxw.rml_parse):

=== modified file 'account_statement_ext/statement_view.xml'
--- account_statement_ext/statement_view.xml	2013-06-28 15:00:20 +0000
+++ account_statement_ext/statement_view.xml	2014-01-05 05:46:45 +0000
@@ -96,13 +96,9 @@
       <field name="model">account.bank.statement</field>
       <field name="inherit_id" ref="account.view_bank_statement_form"/>
       <field name="type">form</field>
-      <field name="arch" type="xml">
+      <field name="arch" type="xml" >
 
           <!-- Add before the group : profile and related infos -->
-          <field name="journal_id" position="attributes">
-              <attribute name="invisible">True</attribute>
-          </field>
-
           <label for="name" position="before">
               <group>
                   <field name="profile_id" select="1" required="1" on_change="onchange_imp_config_id(profile_id)" widget="selection"/>
@@ -110,7 +106,11 @@
               </group>
           </label>
 
-          # Make balance visible or not depending on profile
+          <field name="journal_id" position="attributes">
+              <attribute name="invisible">True</attribute>
+          </field>
+
+          <!-- Make balance visible or not depending on profile -->
           <field name="balance_start" position="attributes">
               <attribute name="attrs">{'invisible':[('balance_check','=',False)]}</attribute>
           </field>
@@ -128,7 +128,7 @@
           <xpath expr="//field[@name='line_ids']/form//field[@name='date']" position="before">
               <field name="id" readonly="1" />
           </xpath>
-          # Adapt onchange signature
+          <!-- Adapt onchange signature -->
           <xpath expr="//field[@name='line_ids']/tree/field[@name='partner_id']" position="replace">
               <field name="partner_id" on_change="onchange_partner_id(partner_id,parent.profile_id)" domain="['|',('parent_id','=',False),('is_company','=',True)]"/>
           </xpath>
@@ -139,7 +139,7 @@
           <xpath expr="//field[@name='line_ids']/form//field[@name='type']" position="replace">
                <field name="type" on_change="onchange_type(partner_id, type, parent.profile_id)"/>
           </xpath>
-          # also set type hidden as it has no impact on reconciliation
+          <!-- also set type hidden as it has no impact on reconciliation -->
           <xpath expr="//field[@name='line_ids']/tree/field[@name='type']" position="replace">
                <field name="type" on_change="onchange_type(partner_id, type, parent.profile_id)" invisible="1"/>
           </xpath>

=== modified file 'account_statement_ofx_import/parser/ofx_parser.py'
--- account_statement_ofx_import/parser/ofx_parser.py	2013-11-04 12:22:39 +0000
+++ account_statement_ofx_import/parser/ofx_parser.py	2014-01-05 05:46:45 +0000
@@ -18,11 +18,13 @@
 #    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 ##############################################################################
-from openerp.tools.translate import _
-from account_statement_base_import.parser import BankStatementImportParser
+
 import tempfile
 import datetime
 
+from openerp.tools.translate import _
+from openerp.addons.account_statement_base_import.parser import BankStatementImportParser
+
 try:
     import ofxparse
 except: