banking-addons-team team mailing list archive

["Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>]

Review: Needs Fixing

With your changes, the 'AccountStatementProfil._get_callable' function no more return a list of callable but a sorted list of browser_record of account.statement.completion.rule. _get_rule_ids could be a better name?

At line 29, len(inspect.getargspec(method_to_call)) will always return 5. 
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/possible_use_completion_rule_instance/+merge/201604
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~acsone-openerp/banking-addons/possible_use_completion_rule_instance into lp:banking-addons/bank-statement-reconcile-7.0.