banking-addons-team team mailing list archive

Thread
Date

Re: lp:~acsone-openerp/banking-addons/possible_use_completion_rule_instance into lp:banking-addons/bank-statement-reconcile-7.0

To: "Laetitia Gangloff \(Acsone\)" <laetitia.gangloff@xxxxxxxxx>
From: Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>
Date: Sun, 19 Jan 2014 18:37:00 -0000
In-reply-to: <20140114151126.24602.52270.launchpad@ackee.canonical.com>
Reply-to: mp+201604@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review and test

Laetitia,

Can you just make the rule name more explicit?

I suggest 'Set account for line labels matching a regular expression' instead of 'Set account'.

Otherwise LGTM.

-sbi
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/possible_use_completion_rule_instance/+merge/201604
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

lp:~acsone-openerp/banking-addons/possible_use_completion_rule_instance into lp:banking-addons/bank-statement-reconcile-7.0
From: Laetitia Gangloff (Acsone), 2014-01-14