banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Approve

Thank you for your response, Alexis. I see it is a little more complicated than a simple if-clause. An alternative solution could be to throw proper ValueError (if it is empty) and TypeError (if it is not a str/unicode) exceptions in _prepare_field, so you could catch these specific exceptions in the try/catch block. But if these were to occur elsewhere, the user would be confronted with a backtrace instead of a popup error from the except_orm.

Given the deadline, maybe this issue should better be put this on the todo list so I'll approve this one now.


-- 
https://code.launchpad.net/~akretion-team/banking-addons/70-sepa-trf-dd-updates/+merge/200019
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.