banking-addons-team team mailing list archive

["Ruchir Shukla\(BizzAppDev\)" <ruchiryshukla@xxxxxxxxx>]

Ruchir Shukla(BizzAppDev) has proposed merging lp:~ruchir.shukla/banking-addons/banking-addons-link_partner_without_remote_owner into lp:banking-addons.

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-link_partner_without_remote_owner/+merge/202408

When no partner name or account could be found in the bank statement file, it was not possible to link a partner with the "link partner" button. This change makes that possible. Now you can connect the found bank account to an existing partner or create a new partner.
-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-link_partner_without_remote_owner/+merge/202408
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~ruchir.shukla/banking-addons/banking-addons-link_partner_without_remote_owner into lp:banking-addons.

=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py	2014-01-11 16:06:19 +0000
+++ account_banking/banking_import_transaction.py	2014-01-21 08:38:58 +0000
@@ -1409,7 +1409,6 @@
                 line.state == 'draft'
                 and not line.partner_id
                 and line.import_transaction_id
-                and line.import_transaction_id.remote_owner
                 and line.import_transaction_id.remote_account)
         return res
 

=== modified file 'account_banking/wizard/link_partner.py'
--- account_banking/wizard/link_partner.py	2013-09-23 09:10:01 +0000
+++ account_banking/wizard/link_partner.py	2014-01-21 08:38:58 +0000
@@ -87,7 +87,7 @@
                     _('Error'),
                     _('Statement line is already linked to a bank account '))
             
-            if not(transaction and transaction.remote_owner
+            if not(transaction
                    and transaction.remote_account):
                 raise orm.except_orm(
                     _('Error'),
@@ -117,6 +117,8 @@
                     self.pool, cr, uid, transaction, context=context)
             if not vals.get('name'):
                 vals['name'] = transaction.remote_owner
+                if not vals['name']:
+                    vals['name'] = '/'
             if not vals.get('remote_account'):
                 vals['remote_account'] = transaction.remote_account