← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~ruchir.shukla/banking-addons/banking-addons-change-account_bank_transaction_line into lp:banking-addons

 

Review: Needs Information

Thanks for the contribution! I have some questions about the module:

- Can you tell me why it is not easy to change the account?

- Erwin van der Ploeg recently filed this bug report, which describes that changing the journal account can be deceptive in some circumstances: lp:1266890. Do you take this into account?

- L.257: I don't think account.account in my databases have a journal_id. Is this a customization of yours?

Apart from that, I'll have some nits but I'd like to get some more clarity on the above.

-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-change-account_bank_transaction_line/+merge/202409
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.


References